feat(data-point): Remove predefined hash and collection execution order #218
Conversation
…process arrays rename getTypeModifier to normalizeTypeCheckSource
…ection to use more than one modifier, use a compose array BREAKING CHANGE: No longer possible to use multiple modifiers without a compose array ViacomInc#73
| parseCompose.validateCompose(entity.id, composeSpec, modifierKeys) | ||
| if (composeSpec.length) { | ||
| entity.compose = createCompose(composeSpec) | ||
| const compose = parseCompose.parse(id, modifierKeys, spec) |
There was a problem hiding this comment.
refactored parseCompose so that all the functionality is contained by the parse function (instead of needing to individually call validateComposeModifiers, parse, and validateCompose)
| map: '$a', | ||
| find: '$a', | ||
| filter: '$a' | ||
| }) |
There was a problem hiding this comment.
this is no longer a valid object, because map / filter / find would need to be inside compose
…ass is-it-pretty.sh
| value: {}, | ||
| 'inputType': 'object', | ||
|
|
||
| compose: [{ |
There was a problem hiding this comment.
jcodeshift adds the empty line before compose. not sure how to prevent that...
There was a problem hiding this comment.
That's interesting, and hard to ping down. This is the closest information I can find to it. benjamn/recast#147
Is this a big deal to try to "fix" or are we OK with leaving it? I don't think it's worth the effort to solve this as any source files changed by the codemod might go through a linter/formatter by users anyway and leave/change these empty lines on their own.
There was a problem hiding this comment.
I agree that it's not worth trying to fix
| execute('collection', ['filter', 'map', 'find']) | ||
| execute('hash', ['omitKeys', 'pickKeys', 'mapKeys', 'addValues', 'addKeys']) | ||
|
|
||
| return root.toSource() |
There was a problem hiding this comment.
In the codemod for changing access to the acc root we have a means of checking the quote style to preserve it. Do you think it's worth adding that here? If so, it might be worth pulling the function that's used into a utility while we're at it.
| format( | ||
| 'Entity "%s" has invalid modifiers, when using multiple keys they should be added through the "compose" property.\nValid modifiers: %s.\nFor more info: %s', | ||
| entityId, | ||
| specKeys.join(', '), |
There was a problem hiding this comment.
should this be validKeys instead of specKeys.join(', ')?
What: closes #73, and has a codemod because it's a breaking change
Why: Makes it easier to understand
hashandcollectionentity definitions without consulting the readme, because the execution order for "modifiers" is always defined by the order of thecomposearrayHow: Refactored
parse-compose.jsChecklist: