Skip to content

Commit

Permalink
Fix manifest default values to be only required values
Browse files Browse the repository at this point in the history
  • Loading branch information
greeneca committed Jun 23, 2017
1 parent dc317db commit 72f2ed5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion intergration/roku_builder/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def good_config(klass)
devices: {
default: :roku,
roku: {
ip: "192.168.1.127",
ip: "192.168.1.114",
user: "rokudev",
password: "aaaa"
}
Expand Down
3 changes: 1 addition & 2 deletions lib/roku_builder/manifest.rb
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,8 @@ def self.default_params
major_version: 1,
minor_version: 0,
build_version: "010101.0001",
mm_icon_focus_fhd: "<insert fhd focus icon url>",
mm_icon_focus_hd: "<insert hd focus icon url>",
mm_icon_focus_sd: "<insert sd focus icon url>"
splash_screen_fhd: "<insert fhd splash screen url>"
}
end
end
Expand Down
3 changes: 1 addition & 2 deletions test/roku_builder/test_manifest.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ def test_manifest_generate
assert !!manifest.major_version
assert !!manifest.minor_version
assert !!manifest.build_version
assert !!manifest.mm_icon_focus_fhd
assert !!manifest.mm_icon_focus_hd
assert !!manifest.mm_icon_focus_sd
assert !!manifest.splash_screen_fhd
end
def test_manifest_increment_build_version
manifest = Manifest.new(config: @config)
Expand Down

0 comments on commit 72f2ed5

Please sign in to comment.