119 fix aliases declaration in pipeline methods #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -74,7 +74,7 @@ class Group(Stage): | |||
|
|
|||
| Attributes: | |||
| ----------- | |||
| - by, str | list[str] | set[str] | dict | None : field or group of fields to group by | |||
| - by (_id), str | list[str] | set[str] | dict | None : field or group of fields to group by | |||
| - query, dict | None : Computed aggregated values (per group) | |||
|
|
|||
There was a problem hiding this comment.
[black-format] reported by reviewdog 🐶
Suggested change
| @@ -77,7 +77,7 @@ class ReplaceRoot(Stage): | |||
| ----------- | |||
|
|
|||
| - statement, dict : the statement generated during instantiation after parsing the other arguments | |||
| - path_to_new_root, str|None : the path to the embedded document to be promoted | |||
| - path_to_new_root (path), str|None : the path to the embedded document to be promoted | |||
| - document, dict|None : document being created and to be set as the new root or expression | |||
|
|
|||
There was a problem hiding this comment.
[black-format] reported by reviewdog 🐶
Suggested change
| @@ -453,7 +451,7 @@ def group(self, *, by:Any|None=None, _id:Any|None=None, query:dict={})->Self: | |||
|
|
|||
There was a problem hiding this comment.
[black-format] reported by reviewdog 🐶
Suggested change
Comment on lines
567
to
+571
| right = right, | ||
| on = on, | ||
| left_on = left_on, | ||
| right_on = right_on, | ||
| name =name | ||
| left_on = left_on or local_field, | ||
| right_on = right_on or foreign_field, | ||
| name = name |
There was a problem hiding this comment.
[black-format] reported by reviewdog 🐶
Suggested change
| right = right, | |
| on = on, | |
| left_on = left_on, | |
| right_on = right_on, | |
| name =name | |
| left_on = left_on or local_field, | |
| right_on = right_on or foreign_field, | |
| name = name | |
| right=right, | |
| on=on, | |
| left_on=left_on or local_field, | |
| right_on=right_on or foreign_field, | |
| name=name, |
| @@ -1376,7 +1383,9 @@ def union_with(self, collection:str, coll:str, pipeline:list[dict]|None=None)->S | |||
| """ | |||
|
|
|||
| self.stages.append( | |||
| UnionWith(collection=collection, pipeline=pipeline) | |||
| UnionWith( | |||
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Unexpected keyword argument "collection" for "UnionWith" [call-arg]
VianneyMI
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.