Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

50-migrate-to-pydantic-v2 #51

Merged
merged 6 commits into from
Jul 23, 2023
Merged

50-migrate-to-pydantic-v2 #51

merged 6 commits into from
Jul 23, 2023

Conversation

VianneyMI
Copy link
Owner

@VianneyMI VianneyMI commented Jul 23, 2023 •
edited
Loading

  • Make package compatible with pydantic v2 while still being comptatible with pydantic V1
  • Under the hood only pydantic V1 is actually used by the package and the V2 features are not exposed by the package

@VianneyMI
Adapt package by tricking imports
09f2f46
@VianneyMI
Fixes
5642dfe 
- Added default values for Optional nullable parameters
- Import ValidationError from v1
@VianneyMI VianneyMI self-assigned this Jul 23, 2023
@VianneyMI VianneyMI linked an issue Jul 23, 2023 that may be closed by this pull request
Migrate to pydantic V2 #50
Closed
@VianneyMI VianneyMI marked this pull request as ready for review July 23, 2023 14:34
@VianneyMI VianneyMI merged commit 8a4385e into main Jul 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VianneyMI VianneyMI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to pydantic V2
1 participant
@VianneyMI