Properly auto-set metadata.max.age.ms when metadata.refresh.interval.…

…ms is disabled (closes confluentinc#1149)
Viasat · Oct 19, 2017 · 7090c82 · 7090c82
1 parent 9211feb
commit 7090c82
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/rdkafka.c b/src/rdkafka.c
@@ -1231,9 +1231,13 @@ rd_kafka_t *rd_kafka_new (rd_kafka_type_t type, rd_kafka_conf_t *conf,
                 return NULL;
         }
 
-        if (use_conf->metadata_max_age_ms == -1)
-                use_conf->metadata_max_age_ms =
-                        use_conf->metadata_refresh_interval_ms * 3;
+        if (use_conf->metadata_max_age_ms == -1) {
+                if (use_conf->metadata_refresh_interval_ms > 0)
+                        use_conf->metadata_max_age_ms =
+                                use_conf->metadata_refresh_interval_ms * 3;
+                else /* use default value of refresh * 3 */
+                        use_conf->metadata_max_age_ms = 5*60*1000 * 3;
+        }
 
 	rd_kafka_global_cnt_incr();