Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue found in JavaScript-Files/begin_round.js [Opened by bitHound] #41

Closed
Vic-ST opened this issue Mar 22, 2017 · 5 comments
Closed

Comments

@Vic-ST
Copy link
Owner

Vic-ST commented Mar 22, 2017

bitHound discovered 1 ComplexFunction in JavaScript-Files/begin_round.js. For details go to bitHound.


I think we should shorten this function! Any ideas @Goredbirds?


Also I finished adding all the players!

@Vic-ST Vic-ST added this to the Upgrades milestone Mar 22, 2017
@Vic-ST Vic-ST self-assigned this Mar 22, 2017
@Vic-ST Vic-ST added this to Bugs in Bugs Mar 22, 2017
@Vic-ST Vic-ST added this to Upgrades in Stores Mar 22, 2017
@ruu5cn
Copy link
Collaborator

ruu5cn commented Mar 22, 2017 via email

@Vic-ST
Copy link
Owner Author

Vic-ST commented Mar 22, 2017

Oh........ Great......... Perfect........
Well, then you want me to fix that right? I'll do that a little bit later because I probably need to get off now. I'll fix that.

@ruu5cn
Copy link
Collaborator

ruu5cn commented Mar 23, 2017

On saturday at codecademy, I'll make the 1-4 player version. Once I'm done with that you can look at the code.

@Vic-ST
Copy link
Owner Author

Vic-ST commented Mar 23, 2017

Why don't you just fork this and do it here! Also, I will not be on Github all day on Saturday because we have the ICCFS.

@Vic-ST Vic-ST added the ready label Mar 23, 2017
@Vic-ST Vic-ST moved this from Upgrades to In progress: Adding more players in Stores Mar 25, 2017
@Vic-ST
Copy link
Owner Author

Vic-ST commented Apr 7, 2017

this issue is now useless

@Vic-ST Vic-ST closed this as completed Apr 7, 2017
@ghost ghost removed the ready label Apr 7, 2017
@Vic-ST Vic-ST moved this from Bugs to Fixes in Bugs Apr 10, 2017
@Vic-ST Vic-ST moved this from In progress: Adding more players to Upgrades(finished) in Stores May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bugs
Fixes
Stores
Upgrades(finished)
Development

No branches or pull requests

2 participants