Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image alt text, fixes #98 #100

Merged
merged 5 commits into from
Oct 10, 2020
Merged

Add image alt text, fixes #98 #100

merged 5 commits into from
Oct 10, 2020

Conversation

JasirZaeem
Copy link
Collaborator

@JasirZaeem JasirZaeem commented Oct 10, 2020

This PR fixes issue #98 I needed to make these changes to fix issue #91 so I will wait for this to be merged before I proceed with that.

Changes:

  • Changed tweet_labels to a dict, random label is chosen from the dict keys, will add definitions in the next PR.
  • Added get_tweet_content, return the tweets text and its label as a dict.
  • Added get_img_for_tweet, takes the texts of the tweet, generates a random image, returns location of the generated image
  • Updated tweet.py to post the tweet along with an image which has its alt text, and then delete the image once posted.

@JasirZaeem
Copy link
Collaborator Author

JasirZaeem commented Oct 10, 2020

I have also created a directory "img_post" where the generated images a stored, and it has a gitignore file so that those files aren't indexed by git as they are temporary

Copy link
Owner

@VickiLanger VickiLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.


Don't forget to follow the bot on Twitter to see the hard work you put in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants