Tweet images instead of text #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated get_tweet() so that it returns a random tweet each time it is called from within a loop.
The program now gets a random tweet from get_tweet.py and prints it on a random image from img_bg. The function "run" takes "x" as a parameter and repeats the above mentioned process for x no of times.
The program uploads an image instead of the tweet. Another parameter could be passed to upload image WITH a tweet.
It assumes that the generated images have the naming convention "post_{no}.png" and are all located in the same directory as the tweet.py file.
It also assumes that there exists atleast 1 image with the above mentioned naming convention in the directory.
bobsany16
reviewed
Oct 9, 2020
"No image exists in working directory" and infinite loop issue resolved. The program now scans and initializes the array "arr" containing image names and tweets every hr with 1 image from the array. get_img_random() is obsolete now, hence is commented out.
updated to include both, post_{no} and post_{no+'a'} files into the array `arr` containing filenames
bobsany16
approved these changes
Oct 9, 2020
VickiLanger
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Thanks for your contribution. I'm excited to see this in production
Don't forget to follow the bot on Twitter to see the hard work you put in.
Ares358
commented
Oct 9, 2020
Comment on lines
+96
to
+99
| run() | ||
|
|
||
| if __name__ == "__main__": | ||
| main() |
There was a problem hiding this comment.
These 4 lines should be replaced with these 2 lines
if __name__ == "__main__":
run()
run() already calls for main() at line 88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #90
Changes made to get_tweet.py :
-updated get_tweet() so that it returns a random tweet each time it is called from within a loop. Before that it returned the same tweet if called from another script.
Changes made to generateImage.py :
-it now takes a random tweet from get_tweet.py and adds it on the images.
-default x and y co-ordinates changed so that the tweet appears in center of the image.
-could be imported into another script and used to generate an array of images via the "run(x)" function which generates x images with random tweets.
Changes made to tweet.py:
-The program uploads an image instead of the tweet. Another parameter could be passed to upload image WITH a tweet.
NOTE: It assumes that the generated images have the naming convention "post_{no}.png" and are all located in the same directory as the tweet.py file. It also assumes that there exists atleast 1 image with the above mentioned naming convention in the directory. If not, the script will enter an infinite loop when get_img_random() is called.