[WIP] Refactor LinkType: use select2 and cache pages tree #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
2.2-1069-cache-data-for-view-reference-select
branch
from
e76777f
to
a575aeb
Compare
alexislefebvre
changed the title
alexislefebvre
force-pushed
the
2.2-1069-cache-data-for-view-reference-select
branch
from
a575aeb
to
50ab4e7
Compare
alexislefebvre
changed the title
|
He's dead right ? |
|
Yes, This PR is not clean enough to be merged. But there is a workaround to the initial problem here: #1069 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Bugfix
This is an alternative to #1074 without the AJAX loading of values.
The modal takes longer to render but once it's loaded, the select2 are usable directly, even if they are laggy.
Purpose
Fixes #1069
BC Break
NO