"List my articles" endpoints, serializations to different Article types #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods provide more specific sets of query parameters to the list articles endpoint to make these use cases simpler to work with.
These endpoints are called at /api/articles/me/* to retrieve articles made by the caller.
|
@andyhaskell thanks for your PR, would you mind adding some tests and fixing the existing ones, please? |
This is so that the different serializations for these endpoints are reflected.
The new error handling in json.Unmarshal on the List method caused this test to error, so to fix the test coverage, this commit has the mock list articles endpoint return a JSON response for the client to unmarshal,
andyhaskell
force-pushed
the
list-my-articles-endpoints
branch
from
68f9e33
to
f90992c
Compare
|
Sounds great, just fixed the new tests, so I'll work on some tests for the new endpoints I added |
Additionally, add test coverage for convenience methods on /articles endpoints, ArticleUpdate deserialization on POST and PUT endpoints
|
@andyhaskell is everything ready from your side? I would like to merge your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following additions to the Go client:
/articles/me/*) for listing the authenticated user's articles/articlesendpoints for listing articles by tag and user so these functionalities can be used without filling out a structArticletype for the list endpoints, POST/PUT payloads