Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token parsing from custom env variable or org token #89

Merged
merged 6 commits into from Oct 11, 2020

Conversation

VictorAvelar
Copy link
Owner

@VictorAvelar VictorAvelar commented Oct 11, 2020

Description

Fixed the mollie client initialization, conceptually the second parameter passed to the NewConfig method should be the name of the environment variable from which the token should be parsed, this behaviour was not accurate and instead, the explicit string was being added as a token.

Motivation and context

Why is this change required? What problem does it solve?

It fixed an error encountered when running the static token auth example code.

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

The existing test suite is passing.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@VictorAvelar VictorAvelar added bug Something isn't working hacktoberfest-accepted Label to identify PRs which must count for hacktoberfest PR count labels Oct 11, 2020
@VictorAvelar VictorAvelar self-assigned this Oct 11, 2020
@VictorAvelar VictorAvelar added this to In progress in Hacktoberfest 2020 via automation Oct 11, 2020
@VictorAvelar VictorAvelar added the important Main or important feature for the client label Oct 11, 2020
@VictorAvelar VictorAvelar merged commit 2aabdd5 into master Oct 11, 2020
Hacktoberfest 2020 automation moved this from In progress to Done Oct 11, 2020
@VictorAvelar VictorAvelar deleted the bugfix/fix-token-parsing branch October 11, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Label to identify PRs which must count for hacktoberfest PR count important Main or important feature for the client
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant