Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can only derive one datatype per module #47

Closed
arianvp opened this issue Apr 1, 2019 · 4 comments
Closed

Can only derive one datatype per module #47

arianvp opened this issue Apr 1, 2019 · 4 comments

Comments

@arianvp
Copy link
Collaborator

arianvp commented Apr 1, 2019

No description provided.

@VictorCMiraldo
Copy link
Owner

True! This issue is also coupled with #34 and #22

Solving the three of them should suffice for a new minor release.

@arianvp , do you need this solved quickly or can you just split datatypes in different modules
a live with this for a while?

@arianvp
Copy link
Collaborator Author

arianvp commented Apr 1, 2019

This is not a blocker for me. Just something I ran into while messing around

@VictorCMiraldo
Copy link
Owner

Awesome, I'll think about a good fix for this, I'm glad we don't have to rush it.

I think the ideal would be to have more control over how the names
are generated in the TH interface. for example:

data BlaBla = ...

deriveFamily ''OpqTypes [t| BlaBla |] names

names :: NamingStructure
names = def { familyName = ("BlaBla_" ++)
            , codesName = ("__" ++) 
            , genPatternSyns = True
            }

What do you think?

@VictorCMiraldo
Copy link
Owner

The naming machinery is not as fancy as proposed here, but this is no longer an issue. I'll close this and open another feature request for the fancy naming machinery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants