Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support azure_sd_config #1364

Closed
mxsiegle opened this issue Jun 10, 2021 · 7 comments
Closed

Support azure_sd_config #1364

mxsiegle opened this issue Jun 10, 2021 · 7 comments
Labels
enhancement New feature or request vmagent

Comments

@mxsiegle
Copy link

Hey,

we are using VMAgent to scrape targets from Openstack and GCP. However, we also have some servers on Azure and noticed that the Azure Service Discovery is not (yet) implemented.
We will be using file_sd_config for the time being but it would be very nice to have native support for Azure in VMAgent, same as Prometheus.

Refer to azure_sd_config at https://prometheus.io/docs/prometheus/latest/configuration/configuration/#azure_sd_config

I'd be happy to test any developments.

Thanks.
@valyala valyala added the enhancement New feature or request label Jun 10, 2021
@t0p4
Copy link

t0p4 commented Aug 30, 2021

is this feature still in development?

@yuriydzobak
Copy link

any update?

@konstantin-kornienko
Copy link

Will be very helpful!

f41gh7 added a commit that referenced this issue Jun 17, 2022
@f41gh7
lib/promscrape: adds azure service discovery
7f4925d 
Adds azure service discovery mechanism
implements authorization with oauth and msi
lists virtual machines and virtual machines managed by scaleSet

#1364
@f41gh7 f41gh7 mentioned this issue Jun 17, 2022
Merged
@f41gh7 f41gh7 added the vmagent label Jun 17, 2022
@f41gh7
Copy link
Contributor

f41gh7 commented Jun 17, 2022

Hello, can you try to build VMAgent from commit 7f4925d and test it?

Build instructions: https://docs.victoriametrics.com/#how-to-build-from-sources

valyala added a commit that referenced this issue Jul 13, 2022
@f41gh7 @hagen1778 @valyala
lib/promscrape: adds azure service discovery (#2743)
7301aa6 
* lib/promscrape: adds azure service discovery
Adds azure service discovery mechanism
implements authorization with oauth and msi
lists virtual machines and virtual machines managed by scaleSet

#1364

* makes linter happy

* Apply suggestions from code review

Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>

* wip

Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
valyala added a commit that referenced this issue Jul 13, 2022
@f41gh7 @hagen1778 @valyala
lib/promscrape: adds azure service discovery (#2743)
c007b12 
* lib/promscrape: adds azure service discovery
Adds azure service discovery mechanism
implements authorization with oauth and msi
lists virtual machines and virtual machines managed by scaleSet

#1364

* makes linter happy

* Apply suggestions from code review

Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>

* wip

Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
@valyala
Copy link
Collaborator

valyala commented Jul 13, 2022

vmagent gained support for azure_sd_configs in the commit 7301aa6 . This commit will be included in the next release. In the meantime it is possible to test it by building vmagent from this commit according to these docs.

@valyala
Copy link
Collaborator

valyala commented Jul 14, 2022

Azure service discovery can be tested in the following vmagent Docker image - docker.io/victoriametrics/vmagent:heads-master-0-gf9500abfe.

@valyala
Copy link
Collaborator

valyala commented Jul 14, 2022

vmagent supports Prometheus-compatible azure_sd_configs starting from v1.79.0. Closing the feature request as done.

@valyala valyala closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request vmagent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@valyala @t0p4 @f41gh7 @konstantin-kornienko @yuriydzobak @mxsiegle