Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster dashboard "vminsert(All)/Rows per insert (All)" is blank #336

Closed
n4mine opened this issue Feb 26, 2020 · 2 comments
Closed

cluster dashboard "vminsert(All)/Rows per insert (All)" is blank #336

n4mine opened this issue Feb 26, 2020 · 2 comments
Labels
bug Something isn't working dashboard VM dashboards for Grafana

Comments

@n4mine
Copy link
Contributor

n4mine commented Feb 26, 2020

Describe the bug
https://grafana.com/grafana/dashboards/11176
the cluster dashboard's panel which vminsert(All)/Rows per insert (All) seems invalid, it's show "No data".

Additional context
the panel's expr is sum(vm_rows_per_insert{job=~"$job", instance=~"$instance", quantile="0.99"}) by (instance) > 0
i didn't found that name vm_rows_per_insert by curl vminsert's /metrics api.

got this:

vm_rows_per_insert_bucket{type="influx",vmrange="9.5e-1...1.0e0"} 14134130
...
vm_rows_per_insert_bucket{type="influx",vmrange="4.0e2...4.5e2"} 5652
vm_rows_per_insert_sum{type="influx"} 758550240
vm_rows_per_insert_count{type="influx"} 36235654
@valyala valyala added the bug Something isn't working label Feb 26, 2020
@valyala
Copy link
Collaborator

valyala commented Feb 26, 2020

oops, v1.34.0 broke the dasboard, since vm_rows_per_insert metric type has been changed from Summary to VictoriaMetrics-specific Histogram.

@hagen1778 , could you publish the updated dashboards for v1.34.0 with the following query on this panel:

histogram_quantile(0.99, sum(increase(vm_rows_per_insert_bucket{job=~"$job", instance=~"$instance"}[5m])) by (instance, vmrange))

Note that the query won't work in Prometheus, since it doesn't know how to deal with VictoriaMetrics histograms. Probably, the panel should be removed from dashboards, since it doesn't contain actionable information.

@hagen1778 hagen1778 added the dashboard VM dashboards for Grafana label Mar 27, 2020
hagen1778 added a commit that referenced this issue Mar 27, 2020
…ames.

The list of changes is following:
* fix Uptime panel column styles according to changes introduced in 6.7 Grafana version
* fix panel `vminsert/Rows per insert` due to metric rename - see #336
* change default datasource to VictoriaMetrics since dashboard now uses MetricsQL for `vminsert/Rows per insert` panel
valyala pushed a commit that referenced this issue Mar 27, 2020
…ames. (#392)

The list of changes is following:
* fix Uptime panel column styles according to changes introduced in 6.7 Grafana version
* fix panel `vminsert/Rows per insert` due to metric rename - see #336
* change default datasource to VictoriaMetrics since dashboard now uses MetricsQL for `vminsert/Rows per insert` panel
@hagen1778
Copy link
Collaborator

@n4mine plz see updated dashboard here https://grafana.com/grafana/dashboards/11176
Thanks for report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboard VM dashboards for Grafana
Projects
None yet
Development

No branches or pull requests

3 participants