Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build QuerierParams behavior in VMALERT restore state #3418

Closed
zhulaker opened this issue Nov 30, 2022 · 2 comments
Closed

Build QuerierParams behavior in VMALERT restore state #3418

zhulaker opened this issue Nov 30, 2022 · 2 comments
Labels
bug Something isn't working vmalert

Comments

@zhulaker
Copy link

Describe the bug
it would be better that when vmalert restore alert state, we should also Build QuerierParams same to recording rule and alert rule, or we will missing our headers in this case.
图片

图片

To Reproduce
the behavior will be when restore restores the state of active alerts basing on previously written time series, the query request to remote storage will missing headers and also EvaluationInterval

Expected behavior
we shuold build QuerierParams in same behaviour to recording rule and alert rule

Logs
图片

Version
1.83.1 also in master
@hagen1778 hagen1778 added vmalert bug Something isn't working labels Nov 30, 2022
hagen1778 added a commit that referenced this issue Nov 30, 2022
@hagen1778
vmalert: properly pass headers during the restore procedure
72014a1 
See #3418

Signed-off-by: hagen1778 <roman@victoriametrics.com>
@hagen1778 hagen1778 mentioned this issue Nov 30, 2022
Merged
@hagen1778
Copy link
Collaborator

hagen1778 commented Nov 30, 2022 •
edited

Thanks for noticing! The headers are now properly set in #3420.
There is no need to add EvaluationInterval, because it only matters on actual rule evaluations. Rules restore is performed on 1h duration and EvaluationInterval will not have an effect.

hagen1778 added a commit that referenced this issue Dec 1, 2022
@hagen1778
vmalert: properly pass headers during the restore procedure (#3420)
8cc4f7e 
See #3418

Signed-off-by: hagen1778 <roman@victoriametrics.com>
valyala pushed a commit that referenced this issue Dec 3, 2022
@hagen1778 @valyala
vmalert: properly pass headers during the restore procedure (#3420)
435f6f3 
See #3418

Signed-off-by: hagen1778 <roman@victoriametrics.com>
@valyala
Copy link
Collaborator

valyala commented Dec 11, 2022

This bug has been fixed in vmalert v1.85.0. Closing the issue as fixed.

@valyala valyala closed this as completed Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working vmalert
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valyala @hagen1778 @zhulaker