Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newrelic agent support #3520

Closed
mightydok opened this issue Dec 21, 2022 · 4 comments
Closed

Newrelic agent support #3520

mightydok opened this issue Dec 21, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request vmagent

Comments

@mightydok
Copy link

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Community need support of newrelic apm agents protocol in victoria metrics
The VM already supports datadog agents, so supporting new agents shouldn't be a problem

Describe alternatives you've considered
No

Additional context
As i know newrelic agents send metrics over http in json format, thas all i know, need further investigation

@zekker6 zekker6 added enhancement New feature or request vmagent labels Dec 22, 2022
@dmitryk-dk
Copy link
Contributor

Hi @mightydok ! Do you have any experience to write metrics from newrelic apm agents to any timeseries database?
I want to know how to define URL where newrelic apm agents should write scraped metrics.

@hagen1778
Copy link
Collaborator

@mightydok or anyone interested in this support. Would you mind taking a look at #4712 and possibly evaluate it for your setup?

valyala added a commit that referenced this issue Oct 15, 2023
…l support

This is a follow-up for f60c08a

Changes:

- Make sure all the urls related to NewRelic protocol start from /newrelic . Previously some urls were started from /api/v1/newrelic

- Remove /api/v1 part from NewRelic urls, since it has no sense

- Remove automatic transformation from CamelCase to snake_case for NewRelic labels and metric names,
  since it may complicate the transition from NewRelic to VictoriaMetrics. Preserve all the metric names and label names,
  so users could query metrics and labels by the same names which are used in NewRelic.
  The automatic transformation from CamelCase to snake_case can be added later as a special action for relabeling rules if needed.

- Properly update per-tenant data ingestion stats at app/vmagent/newrelic/request_handler.go . Previously it was always zero.

- Fix NewRelic urls in vmagent when multitenant data ingestion is enabled. Previously they were mistakenly started from `/`.

- Document NewRelic data ingestion url at docs/Cluster-VictoriaMetrics.md

- Remove superflouos memory allocations at lib/protoparser/newrelic

- Improve tests at lib/protoparser/newrelic/*

Updates #3520
Updates #4712
valyala added a commit that referenced this issue Oct 16, 2023
…l support

This is a follow-up for f60c08a

Changes:

- Make sure all the urls related to NewRelic protocol start from /newrelic . Previously some urls were started from /api/v1/newrelic

- Remove /api/v1 part from NewRelic urls, since it has no sense

- Remove automatic transformation from CamelCase to snake_case for NewRelic labels and metric names,
  since it may complicate the transition from NewRelic to VictoriaMetrics. Preserve all the metric names and label names,
  so users could query metrics and labels by the same names which are used in NewRelic.
  The automatic transformation from CamelCase to snake_case can be added later as a special action for relabeling rules if needed.

- Properly update per-tenant data ingestion stats at app/vmagent/newrelic/request_handler.go . Previously it was always zero.

- Fix NewRelic urls in vmagent when multitenant data ingestion is enabled. Previously they were mistakenly started from `/`.

- Document NewRelic data ingestion url at docs/Cluster-VictoriaMetrics.md

- Remove superflouos memory allocations at lib/protoparser/newrelic

- Improve tests at lib/protoparser/newrelic/*

Updates #3520
Updates #4712
@hagen1778
Copy link
Collaborator

#4712 has been merged and will be included into the next release.

AndrewChubatiuk pushed a commit to AndrewChubatiuk/VictoriaMetrics that referenced this issue Nov 15, 2023
…l support

This is a follow-up for f60c08a

Changes:

- Make sure all the urls related to NewRelic protocol start from /newrelic . Previously some urls were started from /api/v1/newrelic

- Remove /api/v1 part from NewRelic urls, since it has no sense

- Remove automatic transformation from CamelCase to snake_case for NewRelic labels and metric names,
  since it may complicate the transition from NewRelic to VictoriaMetrics. Preserve all the metric names and label names,
  so users could query metrics and labels by the same names which are used in NewRelic.
  The automatic transformation from CamelCase to snake_case can be added later as a special action for relabeling rules if needed.

- Properly update per-tenant data ingestion stats at app/vmagent/newrelic/request_handler.go . Previously it was always zero.

- Fix NewRelic urls in vmagent when multitenant data ingestion is enabled. Previously they were mistakenly started from `/`.

- Document NewRelic data ingestion url at docs/Cluster-VictoriaMetrics.md

- Remove superflouos memory allocations at lib/protoparser/newrelic

- Improve tests at lib/protoparser/newrelic/*

Updates VictoriaMetrics#3520
Updates VictoriaMetrics#4712
@valyala
Copy link
Collaborator

valyala commented Nov 15, 2023

VictoriaMetrics and vmagent can accept data from NewRelic infrastructure agent starting from v1.95.0. See these docs for details.

Closing this feature request as done.

@valyala valyala closed this as completed Nov 15, 2023
valyala added a commit that referenced this issue Nov 15, 2023
… via New Relic protocol now

This is a follow-up for f60c08a
Updates #3520
valyala added a commit that referenced this issue Nov 15, 2023
… via New Relic protocol now

This is a follow-up for f60c08a
Updates #3520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vmagent
Projects
None yet
Development

No branches or pull requests

5 participants