Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream aggregation: support list for match param #4635

Closed
hagen1778 opened this issue Jul 14, 2023 · 1 comment
Closed

stream aggregation: support list for match param #4635

hagen1778 opened this issue Jul 14, 2023 · 1 comment
Labels
enhancement New feature or request streamaggr vmagent

Comments

@hagen1778
Copy link
Collaborator

hagen1778 commented Jul 14, 2023 •
edited

Is your feature request related to a problem? Please describe

Sometimes it is needed to have multiple time series selector in aggregation config, but match can be specified only once.

Describe the solution you'd like

Would be great if match field supported a list of time series selectors. This should simplify configuration from user's perspective:

- match: 
  - http_request_duration_seconds_bucket{env="prod"}
  - http_request_duration_seconds_bucket{env="staging"}
@hagen1778 hagen1778 added enhancement New feature or request vmagent TBD To Be Done labels Jul 14, 2023
valyala added a commit that referenced this issue Jul 25, 2023
@valyala
lib/promrelabel: add support for a list of series selectors at IfExpr…
6265157 
…ession

This makes possible specifying a list of series selectors at the following places:

- Inside `if` option at relabeling rules
- Inside `match` option at stream aggregation rules

Updates #4635
valyala added a commit that referenced this issue Jul 25, 2023
@valyala
lib/promrelabel: add support for a list of series selectors at IfExpr…
6e43664 
…ession

This makes possible specifying a list of series selectors at the following places:

- Inside `if` option at relabeling rules
- Inside `match` option at stream aggregation rules

Updates #4635
valyala added a commit that referenced this issue Jul 25, 2023
@valyala
lib/promrelabel: return correct string representation for IfExpressio…
3179d05 
…n containing a single selector

This is a follow-up for 6265157

Updates #4635
valyala added a commit that referenced this issue Jul 25, 2023
@valyala
lib/promrelabel: return correct string representation for IfExpressio…
ad08d9c 
…n containing a single selector

This is a follow-up for 6265157

Updates #4635
@hagen1778 hagen1778 mentioned this issue Jul 26, 2023
Closed
@valyala
Copy link
Collaborator

valyala commented Jul 28, 2023

VictoriaMetrics and VictoriaLogs support a list of series selectors inside match option starting from v1.92.0. Closing this feature request as done.

@valyala valyala closed this as completed Jul 28, 2023
@valyala valyala removed the TBD To Be Done label Jul 28, 2023
@Haleygo Haleygo mentioned this issue Aug 8, 2023
Merged
valyala added a commit that referenced this issue Aug 14, 2023
@valyala
lib/promrelabel: stop emitting DEBUG log lines when parsing if expr…
63e3571 
…essions

These lines were accidentally left in the commit 6265157

Updates #4635
valyala added a commit that referenced this issue Aug 14, 2023
@valyala
lib/promrelabel: stop emitting DEBUG log lines when parsing if expr…
e8fe00d 
…essions

These lines were accidentally left in the commit 6265157

Updates #4635
valyala added a commit that referenced this issue Aug 17, 2023
@valyala
lib/promrelabel: stop emitting DEBUG log lines when parsing if expr…
c6154f8 
…essions

These lines were accidentally left in the commit 6265157

Updates #4635
valyala added a commit that referenced this issue Aug 17, 2023
@valyala
lib/promrelabel: stop emitting DEBUG log lines when parsing if expr…
5768ac0 
…essions

These lines were accidentally left in the commit 6265157

Updates #4635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request streamaggr vmagent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valyala @Amper @hagen1778