Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmctl: support week step for time-based chunks #4738

Closed
hagen1778 opened this issue Jul 28, 2023 · 1 comment
Closed

vmctl: support week step for time-based chunks #4738

hagen1778 opened this issue Jul 28, 2023 · 1 comment
Assignees
@dmitryk-dk
Labels
enhancement New feature or request vmctl

Comments

@hagen1778
Copy link
Collaborator

Is your feature request related to a problem? Please describe

vmctl supports time-based chunking of migration with the following time units: month, day, hour, minute.

But there is a big difference in time between a day and month.

Describe the solution you'd like

Would be nice to support week time unit for time-based chunking migration.

Describe alternatives you've considered

No response

Additional information

No response
@hagen1778 hagen1778 added enhancement New feature or request vmctl TBD To Be Done labels Jul 28, 2023
@hagen1778 hagen1778 mentioned this issue Jul 28, 2023
Closed
3 tasks
@dmitryk-dk dmitryk-dk self-assigned this Jul 28, 2023
@dmitryk-dk dmitryk-dk mentioned this issue Jul 30, 2023
Merged
hagen1778 pushed a commit that referenced this issue Jul 31, 2023
@dmitryk-dk
app/vmctl: add support the week step for time-based chunks (#4743)
d322ee4 
#4738
@valyala valyala removed the TBD To Be Done label Jul 31, 2023
valyala pushed a commit that referenced this issue Jul 31, 2023
@dmitryk-dk @valyala
app/vmctl: add support the week step for time-based chunks (#4743)
8d0576c 
#4738
@valyala
Copy link
Collaborator

valyala commented Aug 12, 2023

The --vm-native-step-interval command-line flag at vmctl gains support for week option starting from v1.93.0. Closing the feature request as done.

@valyala valyala closed this as completed Aug 12, 2023
valyala added a commit that referenced this issue Aug 12, 2023
@valyala
app/vmctl: document that -vm-native-step-interval command-line option…
f968046 
… now supports `week` value

This is a follow-up for d322ee4

Updates #4738
valyala added a commit that referenced this issue Aug 12, 2023
@valyala
app/vmctl: document that -vm-native-step-interval command-line option…
f7f29a1 
… now supports `week` value

This is a follow-up for d322ee4

Updates #4738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitryk-dk dmitryk-dk

Labels
enhancement New feature or request vmctl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valyala @hagen1778 @dmitryk-dk