Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmagent: properly handle unexpected EOF #4817

Closed
dmitryk-dk opened this issue Aug 11, 2023 · 2 comments
Closed

vmagent: properly handle unexpected EOF #4817

dmitryk-dk opened this issue Aug 11, 2023 · 2 comments
Labels
enhancement New feature or request vmagent

Comments

@dmitryk-dk
Copy link
Contributor

Is your feature request related to a problem? Please describe

When the client closes the connection, vmagent creates a log message with warning severity. See the example below:

cannot read block of data: unexpected EOF

This warning message produces an alert to which the user cannot handle.

Describe the solution you'd like

We can handle unexpected EOF errors like it was done for the vmalert component
https://github.com/VictoriaMetrics/VictoriaMetrics/pull/4146/files

This will prevent producing and firing an alert that which user cannot handle

Describe alternatives you've considered

No response

Additional information

No response

@dmitryk-dk dmitryk-dk added enhancement New feature or request vmagent labels Aug 11, 2023
@hagen1778 hagen1778 added the TBD To Be Done label Aug 15, 2023
hagen1778 pushed a commit that referenced this issue Aug 18, 2023
…ometheus exposition format (#4851)

Previously only io.EOF was handled, and io.ErrUnexpectedEOF was ignored, but it may happen if the client interrupts the connection.

#4817
hagen1778 pushed a commit that referenced this issue Aug 18, 2023
…ometheus exposition format (#4851)

Previously only io.EOF was handled, and io.ErrUnexpectedEOF was ignored, but it may happen if the client interrupts the connection.

#4817
(cherry picked from commit b7d07e5)
@hagen1778
Copy link
Collaborator

The fix was merged here b7d07e5 and will be available in the next release.

valyala added a commit that referenced this issue Aug 28, 2023
valyala added a commit that referenced this issue Aug 28, 2023
valyala pushed a commit that referenced this issue Aug 28, 2023
…ometheus exposition format (#4851)

Previously only io.EOF was handled, and io.ErrUnexpectedEOF was ignored, but it may happen if the client interrupts the connection.

#4817
valyala pushed a commit that referenced this issue Aug 28, 2023
…ometheus exposition format (#4851)

Previously only io.EOF was handled, and io.ErrUnexpectedEOF was ignored, but it may happen if the client interrupts the connection.

#4817
valyala pushed a commit that referenced this issue Aug 28, 2023
…ometheus exposition format (#4851)

Previously only io.EOF was handled, and io.ErrUnexpectedEOF was ignored, but it may happen if the client interrupts the connection.

#4817
valyala pushed a commit that referenced this issue Aug 28, 2023
…ometheus exposition format (#4851)

Previously only io.EOF was handled, and io.ErrUnexpectedEOF was ignored, but it may happen if the client interrupts the connection.

#4817
@valyala
Copy link
Collaborator

valyala commented Oct 2, 2023

Starting from v1.94.0, vmagent shouldn't emit unexpected EOF error logs when the remote side unexpectedly closes connection. Closing this issue as done.

@valyala valyala closed this as completed Oct 2, 2023
@valyala valyala removed the TBD To Be Done label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vmagent
Projects
None yet
Development

No branches or pull requests

3 participants