Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui: auto-suggestion stops working after the server returns big number of results #5736

Closed
valyala opened this issue Jan 31, 2024 · 1 comment
Assignees
Labels
bug Something isn't working vmui

Comments

@valyala
Copy link
Collaborator

valyala commented Jan 31, 2024

Describe the bug

Auto-suggestion stops working after the server returns big number of results, even the number of returned results is smaller than the limit=1000 hardcoded at vmui

To Reproduce

  1. Open https://play.victoriametrics.com/select/accounting/1/6a716b0f-38bc-4856-90ce-448fd713e3fe/prometheus/graph/
  2. Make sure the Autocomplete toggle is disabled.
  3. Open network inspector in the browser and clear the history of network queries there.
  4. Type p in the query input field at vmui and press ctrl+space
  5. Note that vmui sends the request to https://play.victoriametrics.com/select/accounting/1/6a716b0f-38bc-4856-90ce-448fd713e3fe/prometheus/api/v1/label/__name__/values?match%5B%5D=%7B__name__%3D%7E%22.*p.*%22%7D&limit=1000&start=1706652000&end=1706738399.999 and obtains a list of metric names with p char. The list contains 777 items, e.g. its' size is smaller than the limit=1000.
  6. Note that vmui doesn't show a popup with auto-suggestion list of metric names with p char. This isn't OK, since it is expected that it must show the first 50 items from the list with the warning like 50 out of 777 items are displayed - type more chars for more specific suggestions.
  7. Type rocess_cpu in the query input field, so now it contains process_cpu, and press ctrl+enter again.
  8. vmui doesn't send any requests to the server. This is expected behaviour, since it already has an exhaustive list of items with the p char, which has been loaded at the step 5.
  9. vmui doesn't show a short list with metric names containing process_cpu in their names. This is unexpected behavior.

Version

The latest commit in master branch.

Logs

No response

Screenshots

No response

Used command-line flags

No response

Additional information

Related issue - #5472

@valyala valyala added bug Something isn't working vmui labels Jan 31, 2024
valyala added a commit that referenced this issue Feb 14, 2024
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
valyala added a commit that referenced this issue Feb 14, 2024
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
@valyala
Copy link
Collaborator Author

valyala commented Feb 14, 2024

This issue has been fixed in v1.98.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vmui
Projects
None yet
Development

No branches or pull requests

2 participants