Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmalert: support multiple notification urls #584

Closed
datamuc opened this issue Jun 24, 2020 · 1 comment
Closed

vmalert: support multiple notification urls #584

datamuc opened this issue Jun 24, 2020 · 1 comment
Labels
enhancement New feature or request vmalert

Comments

@datamuc
Copy link

datamuc commented Jun 24, 2020

Is your feature request related to a problem? Please describe.

We are running alertmanager as a cluster, in this case the client must send the alerts to all alertmanagers in the cluster in parallel.

Here is the relevant prometheus documentation:
https://github.com/prometheus/alertmanager#high-availability

But vmalert can currently only handle one notification.Url.

Describe the solution you'd like

For example if vmalert can handle the notification.Url option multiple times would solve that for me. Of course vmalert must send the alerts to all supplied urls.
@valyala valyala added the enhancement New feature or request label Jun 24, 2020
hagen1778 added a commit that referenced this issue Jun 28, 2020
@hagen1778
app/vmalert: support multiple notifier urls (#584)
7ffeaa5 
User now can set multiple notifier URLs in the same fashion
as for other vmutils (e.g. vmagent). The same is correct for
TLS setting for every configured URL. Alerts sending is done
in sequential way for respecting the specified URLs order.
@hagen1778 hagen1778 mentioned this issue Jun 28, 2020
Merged
valyala pushed a commit that referenced this issue Jun 29, 2020
@hagen1778
app/vmalert: support multiple notifier urls (#584) (#590)
88538df 
* app/vmalert: support multiple notifier urls (#584)

User now can set multiple notifier URLs in the same fashion
as for other vmutils (e.g. vmagent). The same is correct for
TLS setting for every configured URL. Alerts sending is done
in sequential way for respecting the specified URLs order.

* app/vmalert: add basicAuth support for notifier client (#585)

The change adds possibility to set basicAuth creds for notifier
client in the same fasion as for remote write/read and datasource.
valyala pushed a commit that referenced this issue Jun 29, 2020
@hagen1778 @valyala
app/vmalert: support multiple notifier urls (#584) (#590)
156c83d 
* app/vmalert: support multiple notifier urls (#584)

User now can set multiple notifier URLs in the same fashion
as for other vmutils (e.g. vmagent). The same is correct for
TLS setting for every configured URL. Alerts sending is done
in sequential way for respecting the specified URLs order.

* app/vmalert: add basicAuth support for notifier client (#585)

The change adds possibility to set basicAuth creds for notifier
client in the same fasion as for remote write/read and datasource.
@valyala
Copy link
Collaborator

valyala commented Jul 2, 2020

Support for multiple notifier urls has been added in v1.37.4. Closing the issue as done.

@valyala valyala closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request vmalert
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@datamuc @valyala @hagen1778