Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty metric name in the Grafana dropdowns #600

Closed
Allineer opened this issue Jul 2, 2020 · 5 comments
Closed

Empty metric name in the Grafana dropdowns #600

Allineer opened this issue Jul 2, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@Allineer
Copy link

Allineer commented Jul 2, 2020

Describe the bug

Related to #599

Снимок экрана 2020-07-02 в 15 38 02

Did you see an empty dropdown item before the "alertmanager"?

@valyala valyala added the bug Something isn't working label Jul 2, 2020
@valyala
Copy link
Collaborator

valyala commented Jul 2, 2020

The issue should be fixed in the commit 0b2086b . This commit will be included in the next release. In the mean time the bugfix may be tested by building VictoriaMetrics from the commit according to these docs.

@Allineer
Copy link
Author

Allineer commented Jul 3, 2020

@valyala seems, it's working for me. Thanks.

But I still can’t understand where they come from. I do not have rules that delete all labels and the name of the metric itself.

Exporters used are almost from the list https://github.com/prometheus/prometheus/wiki/Default-port-allocations and, I hope, do not allow yourself to export an empty metric with only a value.

There are two custom exporters, but all the metrics that they exports are all written to the database, all are available.

@Allineer
Copy link
Author

Allineer commented Jul 3, 2020

Maybe it makes sense to add to vmagent the logging of metrics that he is trying to write to the database without a name AND labels? Perhaps it will turn out to get at least some additional information and the answer to the question "Who is to blame?" - vmagent, vm-node or exporters?

@valyala
Copy link
Collaborator

valyala commented Jul 8, 2020

FYI, the commit that prevents from adding and/or selecting metrics with empty label values has been included in v1.38.0.

@Allineer
Copy link
Author

Allineer commented Jul 8, 2020

Thanks!

@Allineer Allineer closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants