New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode handling issue in vmselect #613
Comments
Updates VictoriaMetrics/VictoriaMetrics#613 Previously such char codes couldn't be parsed by JSON parsers.
This should fix incorrect encoding for json strings with char codes below 0x20 Updates #613
This should fix incorrect encoding for json strings with char codes below 0x20 Updates #613
The issue must be fixed in the following commits: @zcavaliero , could you build VictoriaMetrics from these commits according to the following docs and verify whether the issue is fixed there? |
@valyala Can I just build the vmselect or do I need to build all three? |
@valyala Nevermind, I just tested vmselect and everything looks good!! {"status":"success","data":{"resultType":"vector","result":[{"metric":{"name":"cf_application_info","application_id":"foo_bar","application_name":"foo_bar","buildpack":"client-certificate-mapper=1.11.0_RELEASE container-security-provider=1.16.0_RELEASE java-buildpack=\u001b[34mv4.25\u001b[0m-offline-https://github.com/cloudfoundry/java-buildpack.git#349e93b java-main java-opts java-security jvmkill-agent=1.16.0_RELEASE open-jdk...","deployment":"cf","detected_buildpack":"client-certificate-mapper=1.11.0_RELEASE container-security-provider=1.16.0_RELEASE java-buildpack=\u001b[34mv4.25\u001b[0m-offline-https://github.com/cloudfoundry/java-buildpack.git#349e93b java-main java-opts java-security jvmkill-agent=1.16.0_RELEASE open-jdk...","env":"foo_bar","environment":"foo_bar","instance":"foo_bar:443","job":"foo_bar","organization_id":"foo_bar","organization_name":"foo_bar","space_id":"foo_bar","space_name":"instances","stack_id":"foo_bar","state":"STARTED"},"value":[1,"1"]}]}} Will this get put into an official release? Also, thank you so much for the speedy response and fix!! |
Yes, the bugfix will be included in the next release. Thanks for the testing! |
@zcavaliero , the bugfix has been included in v1.38.1 release of VictoriaMetrics. |
I have an issue where prometheus has a label that has a unicode character in it and when grafana pulls the data from promtheus, promtheus handles the conversion. When I do the same query with the vmselect in grafana, the unicode character is not handled the same and returns and error in grafana.
Examples of json returned:
Prometheus result:
{"status":"success","data":{"resultType":"vector","result":[{"metric":{"__name__":"cf_application_info","application_id":"foo_bar","application_name":"foo_bar","buildpack":"client-certificate-mapper=1.11.0_RELEASE container-security-provider=1.16.0_RELEASE java-buildpack=\u001b[34mv4.25\u001b[0m-offline-https://github.com/cloudfoundry/java-buildpack.git#349e93b java-main java-opts java-security jvmkill-agent=1.16.0_RELEASE open-jdk...","deployment":"cf","detected_buildpack":"client-certificate-mapper=1.11.0_RELEASE container-security-provider=1.16.0_RELEASE java-buildpack=\u001b[34mv4.25\u001b[0m-offline-https://github.com/cloudfoundry/java-buildpack.git#349e93b java-main java-opts java-security jvmkill-agent=1.16.0_RELEASE open-jdk...","env":"prod","environment":"foo_bar","instance":"foo_bar:443","job":"cf_exporter","organization_id":"foo_bar","organization_name":"foo_bar","space_id":"foo_bar","space_name":"instances","stack_id":"foo_bar,"state":"STARTED"},"value":[1,"1"]}]}}
vmselect result:
{"status":"success","data":{"resultType":"vector","result":[{"metric":{"__name__":"cf_application_info","application_id":"foo_bar","application_name":"foo_bar","buildpack":"client-certificate-mapper=1.11.0_RELEASE container-security-provider=1.16.0_RELEASE java-buildpack=�[34mv4.25�[0m-offline-https://github.com/cloudfoundry/java-buildpack.git#349e93b java-main java-opts java-security jvmkill-agent=1.16.0_RELEASE open-jdk...","deployment":"cf","detected_buildpack":"client-certificate-mapper=1.11.0_RELEASE container-security-provider=1.16.0_RELEASE java-buildpack=�[34mv4.25�[0m-offline-https://github.com/cloudfoundry/java-buildpack.git#349e93b java-main java-opts java-security jvmkill-agent=1.16.0_RELEASE open-jdk...","env":"prod","environment":"foo_bar","instance":"foo_bar:443","job":"cf_exporter","organization_id":"foo_bar","organization_name":"foo_bar","space_id":"foo_bar","space_name":"instances","stack_id":"foo_bar","state":"STARTED"},"value":[1,"1"]}]}}
The text was updated successfully, but these errors were encountered: