Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the result of offset is abnormal #625

Closed
n4mine opened this issue Jul 14, 2020 · 3 comments
Closed

the result of offset is abnormal #625

n4mine opened this issue Jul 14, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@n4mine
Copy link
Contributor

n4mine commented Jul 14, 2020 •
edited

Describe the bug
after upgrade vmselect from 6f1d926 to 4353ff7
the result of offset is abnormal
i think it relate to 17f175f ?

To Reproduce
q offset 24h from today 00:00 to today 24:00, the result is odd.
from now() to 24:00 is a straight line

Expected behavior
the result of q offset 24h from 00:00 to 24:00 is equal to q from 00:00 - 24h to 24:00 -24h

Screenshots
111

Version

$ ./vmselect-prod -version
vmselect-20200713-124700-heads-cluster-0-g4353ff7e
@valyala valyala added the bug Something isn't working label Jul 14, 2020
valyala added a commit that referenced this issue Jul 14, 2020
@valyala
app/vmselect/prometheus: do not adjust last points in time series wit…
0e7b200 
…h timestamps exceeding the current time

Such timestamps usually mean that the query contains `offset`.
See #625
valyala added a commit that referenced this issue Jul 14, 2020
@valyala
app/vmselect/prometheus: do not adjust last points in time series wit…
25f80d3 
…h timestamps exceeding the current time

Such timestamps usually mean that the query contains `offset`.
See #625
@valyala
Copy link
Collaborator

valyala commented Jul 14, 2020

@n4mine , thanks for the bug report! The bug should be fixed in the commit 0e7b200 .

@n4mine
Copy link
Contributor Author

n4mine commented Jul 14, 2020

confirm, thanks @valyala

@n4mine n4mine closed this as completed Jul 14, 2020
@valyala
Copy link
Collaborator

valyala commented Jul 14, 2020

The bugfix has been included in v1.38.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valyala @n4mine