vmalert: support configuration file for notifiers #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* vmalert notifiers now can be configured via file see https://docs.victoriametrics.com/vmalert.html#notifier-configuration-file * add support of Consul service discovery for notifiers config see #1947 * add UI section for currently loaded/discovered notifiers * deprecate `-rule.configCheckInterval` in favour of `-configCheckInterval` Signed-off-by: hagen1778 <roman@victoriametrics.com>
Codecov Report
@@ Coverage Diff @@
## master #2127 +/- ##
==========================================
+ Coverage 60.31% 60.51% +0.20%
==========================================
Files 240 239 -1
Lines 40269 40279 +10
==========================================
+ Hits 24288 24375 +87
+ Misses 14376 14276 -100
- Partials 1605 1628 +23
Continue to review full report at Codecov.
|
vmalert will repeat service discovery calls if on init first attempts returned nothing. Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
f41gh7
reviewed
Jan 31, 2022
…fiers discovery Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
* move metrics structs used in the main vmalert package to utils so it can be reused by other subpackages * move metrics to alertmanager struct because it should handle those * support metrics registering/unregistering on notifier config changes * change behaviour of `vmalert_alerts_send_errors_total` - it now accounts for failed alerts, not HTTP calls. Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Such situation is expected when user runs only recording rules Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
f41gh7
reviewed
Feb 1, 2022
valyala
pushed a commit
that referenced
this pull request
Feb 2, 2022
vmalert: support configuration file for notifiers * vmalert notifiers now can be configured via file see https://docs.victoriametrics.com/vmalert.html#notifier-configuration-file * add support of Consul service discovery for notifiers config see #1947 * add UI section for currently loaded/discovered notifiers * deprecate `-rule.configCheckInterval` in favour of `-configCheckInterval` * add ability to suppress logs for duplicated targets for notifiers discovery * change behaviour of `vmalert_alerts_send_errors_total` - it now accounts for failed alerts, not HTTP calls.
|
FYI, this pull request has been included into v1.73.0 release. |
This was referenced Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://docs.victoriametrics.com/vmalert.html#notifier-configuration-file
see vmalert to support consul sd for discovering of notifier addresses #1947
-rule.configCheckIntervalin favour of-configCheckIntervalSigned-off-by: hagen1778 roman@victoriametrics.com