Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single dashboards #2492

Merged
merged 7 commits into from Apr 24, 2022
Merged

Single dashboards #2492

merged 7 commits into from Apr 24, 2022

Conversation

hagen1778
Copy link
Collaborator

No description provided.

@hagen1778 hagen1778 added the dashboard VM dashboards for Grafana label Apr 22, 2022
The diskUsage stats panel was showing disk usage without including
size of the index, which is not correct. The filter was removed
to reflect the total disk usage.

#2368

Signed-off-by: hagen1778 <roman@victoriametrics.com>
The adhoc filter allows to quickly apply global filters without
modifying the panels.

Signed-off-by: hagen1778 <roman@victoriametrics.com>
The new panel supposed to reflect the pressure on indexDB
caused by churn rate or new series registration.

Signed-off-by: hagen1778 <roman@victoriametrics.com>
See more context here #1682 (comment)

Signed-off-by: hagen1778 <roman@victoriametrics.com>
Before we used fixed `5m` interval for expressions with `rate` func.
Unfortunately, this interval wasn't a fit for all the cases. So we
switch to `$__rate_interval` instead.

Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Rate over `vm_indexdb_items_added_size_bytes_total` doesn't seem to be useful
on the dasbhoard panel.

Signed-off-by: hagen1778 <roman@victoriametrics.com>
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #2492 (44082fd) into master (8d0fb4d) will increase coverage by 0.16%.
The diff coverage is 64.17%.

@@            Coverage Diff             @@
##           master    #2492      +/-   ##
==========================================
+ Coverage   60.43%   60.59%   +0.16%     
==========================================
  Files         245      245              
  Lines       41881    41915      +34     
==========================================
+ Hits        25310    25398      +88     
+ Misses      14904    14846      -58     
- Partials     1667     1671       +4     
Impacted Files Coverage Δ
lib/promscrape/discovery/kubernetes/api_watcher.go 67.32% <59.61%> (-0.08%) ⬇️
lib/promscrape/config.go 46.87% <80.00%> (+0.77%) ⬆️
lib/bloomfilter/filter.go 100.00% <0.00%> (+2.00%) ⬆️
lib/mergeset/table.go 68.36% <0.00%> (+2.30%) ⬆️
app/vmselect/promql/aggr_incremental.go 87.65% <0.00%> (+3.61%) ⬆️
lib/mergeset/block_stream_reader.go 62.18% <0.00%> (+11.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a0aa2...44082fd. Read the comment docs.

Copy link
Contributor

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit 4c1fbcd into master Apr 24, 2022
@f41gh7 f41gh7 deleted the single-dashboards branch April 24, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard VM dashboards for Grafana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants