vmctl: fix panic on start #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change disables initing the `-version` flag in new `urfave/cli/v2` update. The `-version` flag conflicts with the identical flag from `lib/buildinfo` and causes panic. See #3299 Signed-off-by: hagen1778 <roman@victoriametrics.com>
hagen1778
force-pushed
the
vmctl-fix-panic
branch
from
217d079
to
b5bf989
Compare
Codecov ReportBase: 57.73% // Head: 57.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3300 +/- ##
==========================================
+ Coverage 57.73% 57.80% +0.07%
==========================================
Files 286 286
Lines 48477 48480 +3
==========================================
+ Hits 27986 28023 +37
+ Misses 18694 18655 -39
- Partials 1797 1802 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
valyala
pushed a commit
that referenced
this pull request
Nov 5, 2022
The change disables initing the `-version` flag in new `urfave/cli/v2` update. The `-version` flag conflicts with the identical flag from `lib/buildinfo` and causes panic. See #3299 Signed-off-by: hagen1778 <roman@victoriametrics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change disables initing the
-versionflag in newurfave/cli/v2update. The-versionflag conflicts with the identical flag fromlib/buildinfoand causes panic.See #3299
Signed-off-by: hagen1778 roman@victoriametrics.com