Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui: tips for working with the graph and legend #4045

Merged
merged 4 commits into from Apr 1, 2023
Merged

Conversation

Loori-R
Copy link
Contributor

@Loori-R Loori-R commented Mar 30, 2023

  • add tips for working with the graph and legend
  • add the ability to collapse/expand the legend
Screenshot 2023-03-30 at 21 52 34 Screenshot 2023-03-30 at 22 44 05
image

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.69 ⚠️

Comparison is base (02b714c) 61.14% compared to head (3453401) 58.45%.

❗ Current head 3453401 differs from pull request most recent head 7fa1ff9. Consider uploading reports for the commit 7fa1ff9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4045      +/-   ##
==========================================
- Coverage   61.14%   58.45%   -2.69%     
==========================================
  Files         323      316       -7     
  Lines       58646    52921    -5725     
==========================================
- Hits        35858    30936    -4922     
+ Misses      20705    20065     -640     
+ Partials     2083     1920     -163     

see 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valyala valyala merged commit 4208751 into master Apr 1, 2023
3 checks passed
@valyala valyala deleted the vmui/graph-tips branch April 1, 2023 07:38
@valyala
Copy link
Collaborator

valyala commented Apr 1, 2023

@Loori-R , thanks for the pull request!

valyala added a commit that referenced this pull request Apr 1, 2023
* feat: add tips for working with the graph and legend

* feat: add the ability to collapse the legend

* vmui/docs: add the ability to collapse the legend

---------

Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
@valyala
Copy link
Collaborator

valyala commented Apr 7, 2023

This pull request has been included in v1.90.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants