Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui: enhancements to top queries page #4299

Merged
merged 4 commits into from May 11, 2023
Merged

Conversation

Loori-R
Copy link
Contributor

@Loori-R Loori-R commented May 11, 2023

This pull request introduces several usability improvements to the top queries page in VMUI.

  • An Execute query button has been added to each row. On clicking this button, a new page opens displaying a chart with the selected query.
  • A Copy query button has been added that allows users to easily copy the selected query to the clipboard.
  • The Time Range column has been replaced with the Query Time Interval column. The time intervals are displayed in a more intuitive humanized duration format (for example, 5m, 1h, 5d10h50m20s).

#4292

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (adc5635) 61.18% compared to head (9626049) 61.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4299      +/-   ##
==========================================
+ Coverage   61.18%   61.24%   +0.06%     
==========================================
  Files         330      330              
  Lines       58957    58957              
==========================================
+ Hits        36070    36110      +40     
+ Misses      20904    20876      -28     
+ Partials     1983     1971      -12     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/CHANGELOG.md Outdated Show resolved Hide resolved
@valyala valyala merged commit 1e4a9a8 into master May 11, 2023
3 checks passed
@valyala valyala deleted the vmui/issue-4292/top-queries branch May 11, 2023 20:47
@valyala
Copy link
Collaborator

valyala commented May 11, 2023

@Loori-R , thanks for the pull request!

valyala added a commit that referenced this pull request May 13, 2023
* feat: improvement of the top queries page

* vmui/docs: enhancements to top queries page

* Apply suggestions from code review

---------

Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
@valyala
Copy link
Collaborator

valyala commented May 18, 2023

FYI, this pull request has been included in v1.91.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants