vmctl: finish retries if context canceled #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4442 +/- ##
==========================================
+ Coverage 61.27% 61.30% +0.03%
==========================================
Files 330 330
Lines 59066 59075 +9
==========================================
+ Hits 36194 36218 +24
+ Misses 20892 20881 -11
+ Partials 1980 1976 -4
☔ View full report in Codecov by Sentry. |
zekker6
reviewed
Jun 13, 2023
zekker6
approved these changes
Jun 13, 2023
hagen1778
approved these changes
Jun 13, 2023
|
@dmitryk-dk would you mind adding changelog line? |
hagen1778
approved these changes
Jun 13, 2023
valyala
pushed a commit
that referenced
this pull request
Jul 7, 2023
vmctl: interrupt backoff retries if import context is cancelled Co-authored-by: Roman Khavronenko <roman@victoriametrics.com>
|
FYI, this pull request has been included in vmctl v1.92.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved backoff retry policy for
vmctl.vmctlshould finish retries if the context is canceled.Signed-off-by: dmitryk-dk d.kozlov@victoriametrics.com