lib/vmselectapi: do not send empty label names for labelNames request #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it breaks cluster communication, since vmselect incorrectly reads request buffer, leaving unread data on it #4932
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## cluster #4936 +/- ##
===========================================
- Coverage 59.32% 59.31% -0.02%
===========================================
Files 394 394
Lines 74759 74759
===========================================
- Hits 44353 44344 -9
- Misses 27976 27978 +2
- Partials 2430 2437 +7 ☔ View full report in Codecov by Sentry. |
valyala
reviewed
Sep 1, 2023
lib/vmselectapi/server.go
Outdated
| @@ -919,6 +923,9 @@ func (s *Server) processTenants(ctx *vmselectRequestCtx) error { | |||
|
|
|||
| // Send tenants to vmselect | |||
| for _, tenant := range tenants { | |||
| if len(tenant) == 0 { | |||
| return fmt.Errorf("BUG: unexpected empty tenant name") | |||
There was a problem hiding this comment.
I think it is better to just skip an empty tenant and log this issue instead of returning the error, since this error makes the tenant API unusable.
valyala
approved these changes
Sep 1, 2023
|
@f41gh7 , thanks for the bugfix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it breaks cluster communication, since vmselect incorrectly reads request buffer, leaving unread data on it #4932