vmui: update information about tsdb usage in cluster version #5004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5004 +/- ##
==========================================
- Coverage 60.40% 60.34% -0.06%
==========================================
Files 388 388
Lines 72732 72821 +89
==========================================
+ Hits 43932 43945 +13
- Misses 26402 26474 +72
- Partials 2398 2402 +4 ☔ View full report in Codecov by Sentry. |
Loori-R
reviewed
Sep 15, 2023
app/vmui/packages/vmui/src/pages/CardinalityPanel/CardinalityTips/index.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/CardinalityPanel/CardinalityTips/index.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/CardinalityPanel/hooks/useCardinalityFetch.ts
Outdated
Show resolved
Hide resolved
valyala
pushed a commit
that referenced
this pull request
Oct 1, 2023
* vmui: update information about tsdb usage in cluster version * vmui: cleanup * vmui: add CHANGELOG.md * vmui: cleanup * vmui: update logic, move information to the visible place * app/vmui: remove values fetch, update documentation for cardinality explorer * app/vmui: update CHANGELOG.md
AndrewChubatiuk
pushed a commit
to AndrewChubatiuk/VictoriaMetrics
that referenced
this pull request
Oct 3, 2023
…aMetrics#5004) * vmui: update information about tsdb usage in cluster version * vmui: cleanup * vmui: add CHANGELOG.md * vmui: cleanup * vmui: update logic, move information to the visible place * app/vmui: remove values fetch, update documentation for cardinality explorer * app/vmui: update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improvement adds explanations and expectations to the number of label values on Cardinality Explorer. This explanation is only visible for cluster installation because only in the cluster version the same label could have different values on each node.
Information was added to the documentation module.
Related issue: #3070
Signed-off-by: dmitryk-dk d.kozlov@victoriametrics.com