Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui: add storage for query history #5022

Merged
merged 4 commits into from Oct 2, 2023
Merged

Conversation

Loori-R
Copy link
Contributor

@Loori-R Loori-R commented Sep 19, 2023

Query History View Update

  • Added three new tabs: Session History, Saved History, and Favorite queries.

Session History:

  • Contains the query history from the current page for each field.
  • Not saved permanently.
  • Limit: 25 queries per field.

Saved History:

  • Stores the query history across all tabs in the order of execution.
  • Stored in localStorage.
  • Limit: 100 queries in total (25 for each field * 4).

Favorite queries:

  • Holds the user's marked favorite queries.
  • Stored in localStorage.
Screenshots showing examples of concurrent queries executed from two different tabs:

image
image

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9310e9f) 60.37% compared to head (8591aa6) 60.36%.
Report is 14 commits behind head on master.

❗ Current head 8591aa6 differs from pull request most recent head 144f2d7. Consider uploading reports for the commit 144f2d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5022      +/-   ##
==========================================
- Coverage   60.37%   60.36%   -0.01%     
==========================================
  Files         388      388              
  Lines       72814    72832      +18     
==========================================
+ Hits        43958    43967       +9     
- Misses      26458    26467       +9     
  Partials     2398     2398              

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valyala valyala merged commit f39045e into master Oct 2, 2023
5 of 6 checks passed
@valyala valyala deleted the vmui/query-history-storage branch October 2, 2023 19:41
@valyala
Copy link
Collaborator

valyala commented Oct 2, 2023

@Loori-R , thanks for the pull request!

valyala pushed a commit that referenced this pull request Oct 2, 2023
* vmui: add storage for query history

* docs/vmui: add storage for query history
@valyala
Copy link
Collaborator

valyala commented Oct 2, 2023

FYI, this pull request has been included into v1.94.0.

AndrewChubatiuk pushed a commit to AndrewChubatiuk/VictoriaMetrics that referenced this pull request Oct 3, 2023
* vmui: add storage for query history

* docs/vmui: add storage for query history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants