lib/storage: do not create tsid if metric contains stale marker(#5069) #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5174 +/- ##
==========================================
+ Coverage 60.18% 60.20% +0.02%
==========================================
Files 398 397 -1
Lines 74083 74024 -59
==========================================
- Hits 44589 44569 -20
+ Misses 26988 26962 -26
+ Partials 2506 2493 -13
☔ View full report in Codecov by Sentry. |
3 tasks
valyala
pushed a commit
that referenced
this pull request
Oct 26, 2023
valyala
pushed a commit
that referenced
this pull request
Oct 27, 2023
valyala
pushed a commit
that referenced
this pull request
Oct 27, 2023
|
FYI, this pull request has been included in v1.93.7 LTS release |
AndrewChubatiuk
pushed a commit
to AndrewChubatiuk/VictoriaMetrics
that referenced
this pull request
Nov 15, 2023
|
FYI, this pull request has been included in v1.95.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the series were deleted and series are no longer ingested into VM, we still get those series recreated in index db because of how stale markers logic works. The solution in this PR is to not add TSID if:
Resolves #5069