app/vmselect: fixes datarace caused by incorrect query tracer usage #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was incorrecly captured by goroutine function during for range loop #5319
zekker6
approved these changes
Nov 14, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## cluster #5320 +/- ##
===========================================
- Coverage 58.92% 58.89% -0.03%
===========================================
Files 405 405
Lines 76903 76903
===========================================
- Hits 45312 45289 -23
- Misses 29081 29097 +16
- Partials 2510 2517 +7 ☔ View full report in Codecov by Sentry. |
| timeseriesWorker(qtChild, workChs, workerID) | ||
| qtChild.Done() | ||
| wg.Done() | ||
| }(uint(i)) | ||
| }(uint(i), qtChild) |
There was a problem hiding this comment.
According to my tests, it seems that not the root cause.
Most likely related code maybe:
- https://github.com/VictoriaMetrics/VictoriaMetrics/blob/v1.93.7-cluster/app/vmselect/netstorage/netstorage.go#L1700-L1706
- https://github.com/VictoriaMetrics/VictoriaMetrics/blob/v1.93.7-cluster/app/vmselect/netstorage/netstorage.go#L1790-L1800
With skipSlowReplicas set, collectResults will not wait all storage node result. When marshaling the query tracer, the later storage result will be received and update query tracer concurrently, which caused data race, and maybe panic.
There was a problem hiding this comment.
Yes, marshaling causes this data race most likely. Need to properly fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was incorrecly captured by goroutine function during for range loop #5319