Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui: fix display Popper.tsx #5842

Merged
merged 3 commits into from Feb 22, 2024
Merged

vmui: fix display Popper.tsx #5842

merged 3 commits into from Feb 22, 2024

Conversation

Loori-R
Copy link
Contributor

@Loori-R Loori-R commented Feb 21, 2024

This pull request fixes the display of Popper in some cases:

  • After closing the autocomplete list by clicking outside the field, the list would not display when entering a new value.
  • With a long expr, the autocomplete list was displayed outside the browser boundaries.

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valyala valyala merged commit 9e44870 into master Feb 22, 2024
1 check was pending
@valyala valyala deleted the vmui/fix-display-popper branch February 22, 2024 23:32
@valyala
Copy link
Collaborator

valyala commented Feb 22, 2024

@Loori-R , thanks for the fix!

valyala added a commit that referenced this pull request Feb 22, 2024
* vmui: fix display Popper.tsx

* vmui/docs: fix display Popper.tsx

---------

Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
@valyala
Copy link
Collaborator

valyala commented Mar 1, 2024

FYI, this fix has been included in v1.99.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants