[VMAlert] Fix error log when remoteWrite queue size is full #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 67.95% 67.93% -0.02%
==========================================
Files 154 154
Lines 21297 21297
==========================================
- Hits 14472 14469 -3
- Misses 5664 5667 +3
Partials 1161 1161
Continue to review full report at Codecov.
|
valyala
approved these changes
Jul 3, 2020
|
@weenxin , thanks for the contribution! |
valyala
pushed a commit
that referenced
this pull request
Jul 3, 2020
* Fix Auto metrics relabeled errors * Finalize auto-genenated Labels * Fix Test Errors * fix error logs when queue is full Co-authored-by: xinyulong <xinyulong@kuaishou.com>
|
FYI, the commit has been included in v1.38.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
When remoteWrite Queue is full VMAlert wil log