Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added openbsd implementations #790

Merged
merged 1 commit into from Sep 28, 2020
Merged

added openbsd implementations #790

merged 1 commit into from Sep 28, 2020

Conversation

f41gh7
Copy link
Contributor

@f41gh7 f41gh7 commented Sep 24, 2020

#785

removed fadvise for openbsd, added freespace implemenation for openbsd

#785

removed fadvise for openbsd, added freespace implemenation for openbsd
@f41gh7 f41gh7 added the enhancement New feature or request label Sep 24, 2020
@f41gh7 f41gh7 requested a review from valyala September 24, 2020 19:44
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #790 into master will increase coverage by 0.41%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   65.32%   65.74%   +0.41%     
==========================================
  Files         172      176       +4     
  Lines       20285    20939     +654     
==========================================
+ Hits        13251    13766     +515     
- Misses       5810     5930     +120     
- Partials     1224     1243      +19     
Impacted Files Coverage Δ
lib/fs/fs.go 5.00% <0.00%> (+0.03%) ⬆️
lib/fs/fs_nix.go 0.00% <0.00%> (ø)
lib/mergeset/block_stream_reader.go 49.30% <0.00%> (-13.20%) ⬇️
app/vmalert/remotewrite/remotewrite.go 56.60% <0.00%> (-1.89%) ⬇️
app/vmselect/promql/aggr_incremental.go 87.98% <0.00%> (-1.56%) ⬇️
lib/mergeset/table.go 64.75% <0.00%> (-0.94%) ⬇️
lib/storage/index_db.go 69.29% <0.00%> (-0.06%) ⬇️
lib/cgroup/mem.go 0.00% <0.00%> (ø)
lib/cgroup/cpu.go 24.48% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1e3a0...4c7fd5f. Read the comment docs.

Copy link
Collaborator

@valyala valyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valyala valyala merged commit cc90a54 into master Sep 28, 2020
@valyala valyala deleted the openbsd-build branch September 28, 2020 21:29
valyala pushed a commit that referenced this pull request Sep 28, 2020
#785

removed fadvise for openbsd, added freespace implemenation for openbsd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants