apply review comments

VictoriaMetrics · May 21, 2024 · 7d801f9 · 7d801f9
1 parent 168d1e7
commit 7d801f9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/controllers/factory/alertmanager/statefulset.go b/controllers/factory/alertmanager/statefulset.go
@@ -518,10 +518,6 @@ func createDefaultAMConfig(ctx context.Context, cr *victoriametricsv1beta1.VMAle
 		return err
 	}
 
-	if err := finalize.FreeIfNeeded(ctx, rclient, &existAMSecretConfig); err != nil {
-		return err
-	}
-
 	newAMSecretConfig.Annotations = labels.Merge(existAMSecretConfig.Annotations, newAMSecretConfig.Annotations)
 	newAMSecretConfig.Finalizers = victoriametricsv1beta1.MergeFinalizers(&existAMSecretConfig, victoriametricsv1beta1.FinalizerName)
 	return rclient.Update(ctx, newAMSecretConfig)

diff --git a/controllers/factory/vmsingle/vmsingle.go b/controllers/factory/vmsingle/vmsingle.go
@@ -449,6 +449,7 @@ func CreateOrUpdateVMSingleStreamAggrConfig(ctx context.Context, cr *victoriamet
 		if errors.IsNotFound(err) {
 			return rclient.Create(ctx, streamAggrCM)
 		}
+		return fmt.Errorf("cannot fetch exist configmap for vmsingle streamAggr: %w", err)
 	}
 	if err := finalize.FreeIfNeeded(ctx, rclient, &existCM); err != nil {
 		return err