Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log level doesn't change when args are passed in #281

Closed
Blargansmarf opened this issue Jul 14, 2021 · 2 comments
Closed

Log level doesn't change when args are passed in #281

Blargansmarf opened this issue Jul 14, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Blargansmarf
Copy link

Setting --zap-log-level=error and --loggerLevel=ERROR don't actually change the level of logs. It always defaults to INFO level. Deployment yaml included below, please let me know if i'm just dumb about this.

apiVersion: apps/v1
kind: Deployment
metadata:
  name: victoria-metrics-operator
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: victoria-metrics-operator
      app.kubernetes.io/instance: victoria-metrics-operator
  template:
    metadata:
      labels:
        app.kubernetes.io/name: victoria-metrics-operator
        app.kubernetes.io/instance: victoria-metrics-operator
    spec:
      nodeSelector: {{ .Values.defaultNodeSelector | toYaml | nindent 8 }}
      serviceAccountName: victoria-metrics-operator
      containers:
        - name: victoria-metrics-operator
          image: {{ .Values.vmoperator.image.repository }}:{{ .Values.vmoperator.image.tag }}
          imagePullPolicy: IfNotPresent
          env:
            - name: WATCH_NAMESPACE
              value: ""
            - name: POD_NAME
              valueFrom:
                fieldRef:
                  fieldPath: metadata.name
            - name: OPERATOR_NAME
              value: victoria-metrics-operator
          args:
            - --zap-log-level=error
            - --loggerLevel=ERROR
          command:
            - manager
          resources:
            limits:
              cpu: 4
              memory: 4Gi
            requests:
              cpu: 2
              memory: 2Gi
f41gh7 added a commit that referenced this issue Jul 16, 2021
@f41gh7 f41gh7 added the bug Something isn't working label Jul 16, 2021
@f41gh7
Copy link
Collaborator

f41gh7 commented Jul 16, 2021

Thanks for reporting, this bug will be fixed at the next release. For now, main logger level configured by flag: --zap-log-level

@f41gh7
Copy link
Collaborator

f41gh7 commented Jul 28, 2021

Added to the 0.17.1 release

@f41gh7 f41gh7 closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants