Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flag --envflag.enable support #89

Closed
f41gh7 opened this issue Sep 23, 2020 · 0 comments
Closed

add flag --envflag.enable support #89

f41gh7 opened this issue Sep 23, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@f41gh7
Copy link
Collaborator

f41gh7 commented Sep 23, 2020

There is a problem with environment variables that we pass to VM applications, if flag --envflag.enable=true is not set, env vars will be ignored. link: https://github.com/VictoriaMetrics/VictoriaMetrics#environment-variables
@f41gh7 f41gh7 added the bug Something isn't working label Sep 23, 2020
f41gh7 added a commit that referenced this issue Oct 5, 2020
@f41gh7
fixes env variables support,
413696a 
for reading env variables flag must be enabled.
#89
f41gh7 added a commit that referenced this issue Oct 6, 2020
@f41gh7
Fixes env varibles #89 (#91)
4c4fa48 
* added tests for prometheus converter

* fixes env variables support,
for reading env variables flag must be enabled.
#89

* fix linter error
@f41gh7 f41gh7 closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@f41gh7