-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: remove invalid command flags like -loggerJSONFields
#963
Comments
Hi, |
@Haleygo In other words, this image: https://hub.docker.com/r/victoriametrics/operator I'm deploying with the helm chart and using template:
metadata:
creationTimestamp: null
labels:
app.kubernetes.io/instance: victoria-metrics-operator
app.kubernetes.io/name: victoria-metrics-operator
spec:
containers:
- args:
- --zap-log-level=info
- --enable-leader-election
- --loggerFormat=json
- --loggerJSONFields=ts:timestamp,msg:message,level:severity
command:
- manager
env:
- name: WATCH_NAMESPACE
- name: POD_NAME
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.name
- name: OPERATOR_NAME
value: victoria-metrics-operator
- name: VM_PSPAUTOCREATEENABLED
value: "false"
- name: VM_ENABLEDPROMETHEUSCONVERTEROWNERREFERENCES
value: "false"
image: victoriametrics/operator:v0.44.0
But the log fields are not remapped in the operator pod. |
Okay, thanks for clarification. |
loggerJSONFields
-loggerJSONFields
explicitly bind only needed flags to the manager. removes VictoriaMetrics httpserver for debug pprof. Use built-in pprof manager httpserver #963
* internal/manager: removes transitive dependency flags explicitly bind only needed flags to the manager. removes VictoriaMetrics httpserver for debug pprof. Use built-in pprof manager httpserver #963 * fixes linter warnings * Makefile: adds /internal packages to linter args
Changes was included to v0.45.0 release. Operator now longer exposes VM related flags. |
Is it possible for support for
loggerJSONFields
, as with other VM components, to be added to the operator? The operator seems to output in json by default, but the fields are not configurable from what I can tell.I added this to the values.yaml for the Helm chart with no success using 0.44.0:
The text was updated successfully, but these errors were encountered: