Fix alertmanager metrics endpoint when routePrefix is configured #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When routePrefix is configured for vmalertmanager, metrics is accessible only at <routePrefix>/metrics. But victoriametrics operator uses the http.pathPrefix extra arg to set the vmservicescrape metrics path. Alertmanager uses a different extra arg "web.route-prefix" to define the route prefix. This is fixed by using the route prefix from "web.route-prefix" extra arg.
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMAlertmanager CR allows us to configure routePrefix field. If this is used, metrics is not accessible at
/metrics(it is only accessible at<routePrefix>/metrics. Currently, the metrics endpoint that comes up in the generated VMServiceScrape of alertmanager is/metrics(even if routePrefix is configured). This PR fixes this by adding the route prefix from routePrefix field of vmalertmanager CR, so that the metrics endpoint points to the right path.