vmalertmanager: fix extraArgs, add two dashes

[flokli]

addExtraArgsOverrideDefaults: add dashes argument

Set it to `-` for all VictoriaMetrics processes, and to `--` for
alertmanager.

This fixes ExtraArgs in the VMAlertmanager resource. Previously, their
keys had to start with an extra `-`.

--

api/*/vmalertmanager_types.go: fix description for ExtraArgs, ExtraEnvs

This is not about VMAuth, but VMAlertmanager.

Fixes #502.

[flokli]

I couldn't get make manifests to work, my controller-gen 0.8.0 failed to run for me:

Error: unable to parse option "crd:trivialVersions=true,crdVersions=v1beta1": [unknown argument "trivialVersions" (at <input>:1:16) extra arguments provided: "true,crdVersions=v1beta1" (at <input>:1:17)]
Usage:
  controller-gen [flags]

I edited the generated CRDs by hand, please re-run and squash any whitespace/reflow changes into this.

[f41gh7]

LGTM

[f41gh7]

Thanks for contribution!

[f41gh7]

I couldn't get make manifests to work, my controller-gen 0.8.0 failed to run for me:

Error: unable to parse option "crd:trivialVersions=true,crdVersions=v1beta1": [unknown argument "trivialVersions" (at <input>:1:16) extra arguments provided: "true,crdVersions=v1beta1" (at <input>:1:17)]
Usage:
  controller-gen [flags]

I edited the generated CRDs by hand, please re-run and squash any whitespace/reflow changes into this.

I think, all code generation must be moved into docker containers, as VictoriaMetrics does for other components. Will work on it.

[flokli]

I think, all code generation must be moved into docker containers, as VictoriaMetrics does for other components. Will work on it.

I don't think moving everything into docker containers makes things easier. What's probably missing here is a stronger pinning of the version of generator binaries used. Looks like the makefile doesn't install controller-gen if some controller-gen binary is in $PATH, but doesn't do any further checking.