Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on Kubernetes 1.25 #536

Merged
merged 1 commit into from Oct 3, 2022

Conversation

miketth
Copy link
Contributor

@miketth miketth commented Oct 2, 2022

On Kubernetes 1.25, the operator gets into a crash loop, because it tries to get policyv1beta1.PodDisruptionBudget, but it is removed in 1.25. This PR fixes that issue.

Since other resources don't have Owns(&policyv1beta1.PodDisruptionBudget{}), I opted to remove it. In case that is not the direction we want to go about it, feel free to change it.

Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit 68f9067 into VictoriaMetrics:master Oct 3, 2022
@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 3, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants