Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add more default securityContext #712

Merged
merged 4 commits into from Aug 10, 2023

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented Jul 30, 2023

Part of #637

  1. If KubeVersion>=1.20, set FSGroupChangePolicy: onRootMismatchto skip the recursive permission change when the root of the volume already has the correct permissions in default PodSecurityContext.
  2. SeccompProfile: Use RuntimeDefault seccomp profile by default, which is defined by the container runtime, instead of using the Unconfined (seccomp disabled) mode.
  3. Capabilities: {Drop: []v1.Capability{"ALL"}}

@Haleygo Haleygo requested review from Amper and f41gh7 July 30, 2023 10:42
@Haleygo Haleygo changed the title [feature] Add default FSGroupChangePolicy: onRootMismatch when supported [feature] Add more default securityContext Aug 3, 2023
@Haleygo Haleygo force-pushed the add-default-FSGroupChangePolicy branch from 81db679 to 86e4ff2 Compare August 8, 2023 14:29
@Haleygo
Copy link
Contributor Author

Haleygo commented Aug 8, 2023

PTAL @f41gh7 @Amper

f41gh7
f41gh7 previously approved these changes Aug 10, 2023
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haleygo
Copy link
Contributor Author

Haleygo commented Aug 10, 2023

@f41gh7 Need to fix the test, can you please reviewing this again)

Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit 2a03bde into master Aug 10, 2023
3 checks passed
@f41gh7 f41gh7 deleted the add-default-FSGroupChangePolicy branch August 10, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants