vmauth: don't mount config in the vmauth container when using the cus… #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
address #962 |
Haleygo
reviewed
May 23, 2024
…tom reloader When the custom reloader is in use, there is no config volume defined and the vmauth container cannot start with a config volume mount. This patch also adds basic tests for the vmauth pod spec.
jfroy
force-pushed
the
fix-vmauth-config-mount
branch
from
3b1cf0f
to
a55d9ba
Compare
Haleygo
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tom reloader
When the custom reloader is in use, there is no config volume defined and the vmauth container cannot start with a config volume mount.
This patch also adds basic tests for the vmauth pod spec.