New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation should be implements #5

Closed

xiantang opened this issue Mar 12, 2023 · 8 comments

Contributor

xiantang commented Mar 12, 2023

xxxxManager is a struct and it implements Manager interface.
so lsp-lens should display Implements:1 | References: 5

The text was updated successfully, but these errors were encountered:

Contributor Author

xiantang commented Mar 12, 2023

in lspsaga it is also shown as "Implements" and not as "Implementation", I think we have to adapt to lspsaga

Owner

VidocqH commented Mar 12, 2023

OK, that will be an easy work. I use "implementation" because of the request method 'textDocument/implementation'.
哈哈哈哈哈哈哈哈😂

Contributor Author

xiantang commented Mar 12, 2023

谢谢你

Contributor Author

xiantang commented Mar 12, 2023 •

edited

Loading

OK, that will be an easy work. I use "implementation" because of the request method 'textDocument/implementation'. 哈哈哈哈哈哈哈哈😂

I'm willing to contribute the PR

VidocqH added a commit that referenced this issue


          chore: text changes #5 and some styles

24f835c

Owner

VidocqH commented Mar 12, 2023

OK, that will be an easy work. I use "implementation" because of the request method 'textDocument/implementation'. 哈哈哈哈哈哈哈哈😂

I'm willing to contribute the PR

Oh.. I already written it...

Contributor Author

xiantang commented Mar 12, 2023

ok coool

Contributor Author

xiantang commented Mar 12, 2023

let me try

Contributor Author

xiantang commented Mar 12, 2023

Looks good

xiantang closed this as completed

asc11cat mentioned this issue

Outdated implements section keyword in readme #22

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment