Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of PSMTabBarControl #762

Closed
Eitot opened this issue Jan 15, 2017 · 11 comments
Closed

Replacement of PSMTabBarControl #762

Eitot opened this issue Jan 15, 2017 · 11 comments

Comments

@Eitot
Copy link
Contributor

Eitot commented Jan 15, 2017

Once the project switches to Mavericks in the future, it may be worth replacing PSMTabBarControl with this project: https://github.com/MiMo42/MMTabBarView. It has a Yosemite style as well.

It does build with 10.8 without any warnings/issues, but I don’t know whether it actually works on it.

@josh64x2
Copy link
Member

I have a 10.8 VM I can try it on, thanks :)

@josh64x2
Copy link
Member

Unfortunately the demo app crashes on 10.8 :(

@Eitot
Copy link
Contributor Author

Eitot commented Mar 13, 2017

I have done some tests and unfortunately it is not as capable of dealing with Auto Layout as I had hoped. The provided Yosemite style seems to work, because it uses the same ‘hack’ that I used by enforcing an intrinsic size, but the Mavericks style does not without manually adding it. The project maintainer does not seem very active at the moment, with outstanding pull requests.

I am not sure what to do about this. Clearly, MMTabBarView is a more modern code base and it was still updated in December. Small changes can always be made by us.

There is a promising alternative in KPCTabsControl, though it doesn’t look and behave as nicely as MMTabBarView and is not as feature-rich either. The framework is currently built only for Yosemite, but it seems to build without errors for Mavericks too.

@josh64x2
Copy link
Member

josh64x2 commented Jan 5, 2018

Should we look at this for 3.2.0 or save it for 3.3.0?

@barijaona
Copy link
Member

It might be a bit late for 3.2.0, if we maintain the January 28th deadline.
I had a look back at PSMTabBarControl this morning, and spotted a few bugfixes and improvements. I will submit them in a few hours.

@barijaona barijaona modified the milestone: v3.1.11 Jan 20, 2018
@barijaona barijaona changed the title MMTabBarView (10.9+) Replacement of PSMTabBarControl Jan 20, 2018
@barijaona barijaona added this to the v3.3.0 milestone Jan 20, 2018
@TAKeanice
Copy link
Contributor

What is the plan on this? Since I know some stuff about the tabbing system of Vienna now, I could maybe do something about it.

@josh64x2 josh64x2 reopened this Feb 14, 2018
@josh64x2
Copy link
Member

Oops haha @Eitot would know what the plan is I guess. I think we were waiting to drop 10.9 support?

@barijaona
Copy link
Member

My immediate intention is to have our own version of MMTabBarView.

@Eitot
Copy link
Contributor Author

Eitot commented Feb 14, 2018

Forking MMTabBarView is definitely the best solution. It just isn’t maintained and has open pull requests. The only other alternative is KPCTabControl, which isn’t as good, also not actively maintained and requires Yosemitez

@TAKeanice
Copy link
Contributor

I am trying to use MMTabBarView currently. Although they say, that it is not drop-in, initially only very few changes will be required.

@Eitot
Copy link
Contributor Author

Eitot commented Apr 15, 2018

Done in #1110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants