Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Zeitwerk for code loading #1378

Open
Spone opened this issue Jun 2, 2022 · 2 comments
Open

Use Zeitwerk for code loading #1378

Spone opened this issue Jun 2, 2022 · 2 comments

Comments

@Spone
Copy link
Collaborator

Spone commented Jun 2, 2022

Feature request

I was thinking about how to prevent #1377 from happening again, and I'd like to suggest using Zeitwerk for loading the view_component code, instead of all these autoload and require.

See here for what it would look like: https://github.com/fxn/zeitwerk#synopsis

We took this path in view_component-form, so you can have a look at the following PR to see what it took: pantographe/view_component-form#107 (keep in mind that the library is much simpler than view_component).

What do you think?

Motivation

See here for the motivation behind Zeitwerk: https://github.com/fxn/zeitwerk#motivation

@joelhawksley
Copy link
Member

@Spone I'm generally OK with this if you'd like to take it on ❤️

@Spone Spone self-assigned this Jun 2, 2022
@Spone Spone removed their assignment Oct 17, 2023
@Spone
Copy link
Collaborator Author

Spone commented Oct 17, 2023

I was unable to make it work for now, if someone else wants to take this on, I'm unassigning myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants